Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38636: Fix IDLE tab toggle and file indent width #17008

Merged
merged 5 commits into from Nov 20, 2019

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Oct 31, 2019

These format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.

https://bugs.python.org/issue38636

These format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
@terryjreedy
Copy link
Member Author

terryjreedy commented Oct 31, 2019

I might eventually fix this a different way, but this is simple enough to apply by hand to existing 3.7.5 and 3.8.0 installations -- add a line and edit or replace the two that follow.

I intend to add new tests before merging.

@taleinat
Copy link
Contributor

taleinat commented Nov 14, 2019

This is such an obvious fix, I suggest just merging it.

I'm not sure we should be automatically testing that all of our menu options work, anyways.

Copy link
Contributor

@taleinat taleinat left a comment

LGTM

@terryjreedy
Copy link
Member Author

terryjreedy commented Nov 20, 2019

The bug being fixed is a faulty binding, so I would one day like to test them automatically as well as manually (which I forgot here), but another time. I did want to finish the format module tests. Just waiting for CI.

@terryjreedy terryjreedy merged commit b846247 into python:master Nov 20, 2019
@terryjreedy terryjreedy deleted the indents branch Nov 20, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 20, 2019

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

bedevere-bot commented Nov 20, 2019

GH-17274 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

bedevere-bot commented Nov 20, 2019

GH-17275 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants