Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27379: In order to keep backward compatibility, update SocketType's type #14710

Closed
wants to merge 3 commits into from
Closed

bpo-27379: In order to keep backward compatibility, update SocketType's type #14710

wants to merge 3 commits into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jul 11, 2019 •
edited by bedevere-bot

@shihai1991 shihai1991 changed the title bpo-27379: In order to keep backward compatibility, update SocketType's type [WIP] bpo-27379: In order to keep backward compatibility, update SocketType's type Jul 12, 2019
@shihai1991 shihai1991 changed the title [WIP] bpo-27379: In order to keep backward compatibility, update SocketType's type bpo-27379: In order to keep backward compatibility, update SocketType's type Jul 13, 2019
@shihai1991
Copy link
Member Author

shihai1991 commented Jul 14, 2019

@vadmium Hi, Martin. What's your opinion about this bugfix?

@csabella csabella requested a review from vadmium Dec 1, 2019
@csabella csabella requested review from pitrou and removed request for vadmium Jan 17, 2020
@vadmium vadmium mentioned this pull request May 19, 2022
Open
@shihai1991 shihai1991 closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shihai1991 @the-knights-who-say-ni @bedevere-bot