Skip to content

bpo-36277: Add document for pdb debug and retval commands #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2019
Merged

bpo-36277: Add document for pdb debug and retval commands #12872

merged 3 commits into from
Nov 21, 2019

Conversation

nguyendv
Copy link
Contributor

@nguyendv nguyendv commented Apr 18, 2019 •
edited by miss-islington
Loading

@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 18, 2019
@nguyendv
Copy link
Contributor Author

I'm not sure if a News entry is necessary. Please let me know if it's not.

@methane
Copy link
Member

methane commented Apr 22, 2019

NEWS entries are for:

  • Python users can see what's changed from previous release.
  • Credit for the contribution.

If you don't want credit, I think we don't need NEWS entry for this change.

If you want credit, you should add "Patch by Dave Nguyen" at the end of the
NEWS entry, and add "Dave Nguyen" in Misc/ACKS file.

eamanu
eamanu reviewed Apr 22, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the news is not necessary here. But we have to wait for a core dev opinion

Doc/library/pdb.rst
@@ -529,6 +529,14 @@ by the local file.

Quit from the debugger. The program being executed is aborted.

.. pdbcommand:: debug code

Enter a recursive debugger that steps through the code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter in a recursive debugger... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a verbatim copy from docs string. I could be wrong here but "Enter in" doesn't sound better than "Enter"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csabella can you please help us on this one? Thanks :)))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter works here.

remilapeyre
remilapeyre suggested changes May 3, 2019
View reviewed changes
remilapeyre
remilapeyre approved these changes May 3, 2019
View reviewed changes
@JulienPalard JulienPalard reopened this Sep 11, 2019
@JulienPalard
Copy link
Member

(closing / reopening PR to restart failed Travis)

csabella
csabella approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution, @nguyendv!

@miss-islington miss-islington merged commit 9391f6c into python:master Nov 21, 2019
@miss-islington
Copy link
Contributor

Thanks @nguyendv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@nguyendv @miss-islington
bpo-36277: Add document for pdb debug and retval commands (pythonGH-1…
835dc78 
…2872)

https://bugs.python.org/issue36277

Automerge-Triggered-By: @csabella
(cherry picked from commit 9391f6c)

Co-authored-by: Dave Nguyen <dv@dvnguyen.com>
@bedevere-bot
Copy link

GH-17308 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@nguyendv @miss-islington
bpo-36277: Add document for pdb debug and retval commands (pythonGH-1…
a3b26d9 
…2872)

https://bugs.python.org/issue36277

Automerge-Triggered-By: @csabella
(cherry picked from commit 9391f6c)

Co-authored-by: Dave Nguyen <dv@dvnguyen.com>
@bedevere-bot
Copy link

GH-17309 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @nguyendv
bpo-36277: Add document for pdb debug and retval commands (GH-12872)
d5d41d3 
https://bugs.python.org/issue36277

Automerge-Triggered-By: @csabella
(cherry picked from commit 9391f6c)

Co-authored-by: Dave Nguyen <dv@dvnguyen.com>
miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @nguyendv
bpo-36277: Add document for pdb debug and retval commands (GH-12872)
97c301b 
https://bugs.python.org/issue36277

Automerge-Triggered-By: @csabella
(cherry picked from commit 9391f6c)

Co-authored-by: Dave Nguyen <dv@dvnguyen.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@nguyendv
bpo-36277: Add document for pdb debug and retval commands (pythonGH-1…
bd4855e 
…2872)

https://bugs.python.org/issue36277



Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@nguyendv @shihai1991
bpo-36277: Add document for pdb debug and retval commands (pythonGH-1…
e82d64f 
…2872)

https://bugs.python.org/issue36277



Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard left review comments

@eamanu eamanu eamanu left review comments

@csabella csabella csabella approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nguyendv @the-knights-who-say-ni @methane @JulienPalard @miss-islington @bedevere-bot @eamanu @csabella @remilapeyre