Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35003: bin/activate should always be present #18083

Open
wants to merge 2 commits into
base: master
from
Open

bpo-35003: bin/activate should always be present #18083

wants to merge 2 commits into from
+31 −5

Conversation

@earonesty
Copy link

earonesty commented Jan 20, 2020 •
edited

Ensures that the common bin/activate, used by shell scripts on all platforms, is always present on all platforms.

Possibly this should be an option, but that seems like overkill.

https://bugs.python.org/issue35003
@earonesty
bin-activate always present
Loading status checks…
3c8f3c0
@earonesty
lintr
Loading status checks…
7f8151c
@earonesty earonesty marked this pull request as ready for review Jan 20, 2020
@earonesty earonesty requested a review from vsajip as a code owner Jan 20, 2020
@vsajip

This comment has been minimized.

Sign in to view
Copy link
Member

vsajip commented Jan 21, 2020

The Scripts/bin thing is not specific to venv - for whatever reason, the original Windows implementation chose to use "Scripts" rather than "bin" for the executables directory under Windows, and I don't think it can be changed now without affecting backward compatibility. The venv code just fits into the existing, wider theme. My guess is you would need to propose a PEP to move everything over from "Scripts" to "bin" in the Windows Python world, and show that it would not break any existing code anywhere - seems like a tall order.

This issue was already rejected before you added your PR so I'm not sure why you went to the trouble of creating a PR. Thanks for trying to help, but I think this PR should be closed for the above reasons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
4 participants
@earonesty @vsajip @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.