bpo-30757 pyinstaller added to docs, py2exe ref updated #1158
Conversation
|
@denfromufa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @briancurtin and @serhiy-storchaka to be potential reviewers. |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Doc/faq/windows.rst
Outdated
| Python 2.x-based executables, does not yet support Python 3 but a version that | ||
| does is in development. | ||
| See http://cx-freeze.sourceforge.net/ and http://www.pyinstaller.org/ for the | ||
| distutils extensions that allows you to create console and GUI executables |
There was a problem hiding this comment.
PyInstaller isn't a distutils extension (and AFAIK doesn't even have anything to do with distutils).
|
Thanks for the PR, but please open an issue on bugs.python.org. I agree that those two sections can be merged into one. |
|
added issue: http://bugs.python.org/issue30757 |
den-run-ai
changed the title
den-run-ai
changed the title
den-run-ai
changed the title
den-run-ai
changed the title
Doc/faq/windows.rst
Outdated
| from Python code. | ||
| `py2exe <http://www.py2exe.org/>`_, popular extension for building | ||
| Python 2.x-based executables, partially supports Python 3, see | ||
| https://pypi.python.org/pypi/py2exe/. |
There was a problem hiding this comment.
All three of these do the same or similar things but the grouping of the sentences reads oddly. Can we just simplify this to be more of a list? Something like...
The following packages can help with the creation of cross-platform console and GUI executables:
* http://cx-freeze.sourceforge.net/
* http://www.pyinstaller.org/
Additionally, http://www.py2exe.org/ exclusively supports Windows executables.
|
@briancurtin @berkerpeksag please review |
| `py2exe <http://www.py2exe.org/>`_, the most popular extension for building | ||
| Python 2.x-based executables, does not yet support Python 3 but a version that | ||
| does is in development. | ||
| The following 2 packages cx_Freeze and PyInstaller allow |
There was a problem hiding this comment.
I liked Brian's suggested wording more:
The following packages can help with the creation of console and GUI executables:
| does is in development. | ||
| The following 2 packages cx_Freeze and PyInstaller allow | ||
| the creation of cross-platform stand-alone console and GUI executables: | ||
| * http://cx-freeze.sourceforge.net/ |
There was a problem hiding this comment.
`cx_Freeze <http://cx-freeze.sourceforge.net/>`_| The following 2 packages cx_Freeze and PyInstaller allow | ||
| the creation of cross-platform stand-alone console and GUI executables: | ||
| * http://cx-freeze.sourceforge.net/ | ||
| * http://www.pyinstaller.org/ |
There was a problem hiding this comment.
PyInstaller can run on non-Windows platforms too. I think that the best we could do
-
Move the content of this section to end of the "How can I create a stand-alone binary from a Python script?" section in
Doc/faq/programming.rst -
In
Doc/faq/programming.rst, change lines 75 and 76 to.. _faq-create-standalone-binary: How can I create a stand-alone binary from a Python script? -----------------------------------------------------------
-
Remove
Additionally, http://www.py2exe.org/ exclusively supports Windows executables.
and add py2exe to the list:
The following packages can help with the creation of console and GUI executables: * `cx_Freeze <http://cx-freeze.sourceforge.net/>`_ (Cross-platform) * `PyInstaller <http://www.pyinstaller.org/>`_ (Cross-platform) * `py2exe <http://www.py2exe.org/>`_ (Windows only)
-
Then make the "How do I make an executable from a Python script?" section in this file a pointer to the "How can I create a stand-alone binary from a Python script?" section in
Doc/faq/programming.rst:How do I make an executable from a Python script? ------------------------------------------------- See :ref:`faq-create-standalone-binary` for a list of tools that can be used to make executables.
| * http://cx-freeze.sourceforge.net/ | ||
| * http://www.pyinstaller.org/ | ||
|
|
||
| Additionally, http://www.py2exe.org/ exclusively supports Windows executables. |
There was a problem hiding this comment.
`py2exe <http://www.py2exe.org/>`_
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
@denfromufa, please address the code reviews and resolve the merge conflicts. Thank you! |
Based on PR (pythonGH-1158) by Denis Akhiyarov. Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
|
Due to the lack of response (pinged both here and on bpo), I've applied @berkerpeksag and @briancurtin's suggestions and opened #26309. Closing this in favour of the new PR. |
It is not clear why this FAQ item is written in addition to this document:
https://github.com/python/cpython/blob/909a6f626ff343937cd3f06fda996870e7890724/Doc/faq/programming.rst#how-can-i-create-a-stand-alone-binary-from-a-python-script