Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39384 Fix email.generator.BytesGenerator to flatten non-ascii body. #18056
Conversation
Add test for same.
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Jan 19, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
msapiro commentedJan 19, 2020
•
edited by bedevere-bot
Add test for same.
email.generator.BytesGenerator throws uncaught UnicodeEncodeError upon flattening a message with a non-encoded, non-ascii message body. This catches that exception and encodes the body with errors='replace'.
https://bugs.python.org/issue39384