Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39415: Remove unused codes from long/complex/floatobject.c #18105

Merged
merged 1 commit into from Jan 22, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Jan 21, 2020

@corona10 corona10 force-pushed the corona10:bpo-39145 branch from a2aa9a6 to 4933484 Jan 21, 2020
@corona10 corona10 changed the title bpo-39145: Remove unused codes from long/complex/floatobject.c bpo-39415: Remove unused codes from long/complex/floatobject.c Jan 21, 2020
@corona10 corona10 requested review from rhettinger, vstinner and tiran Jan 21, 2020
Copy link
Member

mdickinson left a comment

LGTM

@benjaminp benjaminp merged commit 0d5eac8 into python:master Jan 22, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200121.31 succeeded
Details
bedevere/issue-number Issue number 39415 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Jan 22, 2020

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 22, 2020
….c floatobject.c. (pythonGH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 22, 2020

GH-18112 is a backport of this pull request to the 3.8 branch.

@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Jan 22, 2020

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 22, 2020

GH-18113 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 22, 2020
….c floatobject.c. (pythonGH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jan 22, 2020
….c floatobject.c. (GH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.