Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.7] bpo-39389: gzip: fix compression level metadata (GH-18077) #18101
+31
−3
Conversation
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a gzip member header should indicate whether the DEFLATE algorithm was tuned for speed or compression ratio. Prior to this patch, archives emitted by the `gzip` module always indicated maximum compression. (cherry picked from commit eab3b3f) Co-authored-by: William Chargin <wchargin@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
@wchargin and @serhiy-storchaka: Status check is done, and it's a failure |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@wchargin and @serhiy-storchaka: Status check is done, and it's a failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedJan 21, 2020
•
edited by bedevere-bot
As described in RFC 1952, section 2.3.1, the XFL (eXtra FLags) byte of a
gzip member header should indicate whether the DEFLATE algorithm was
tuned for speed or compression ratio. Prior to this patch, archives
emitted by the
gzipmodule always indicated maximum compression.(cherry picked from commit eab3b3f)
Co-authored-by: William Chargin wchargin@gmail.com
https://bugs.python.org/issue39389