Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-19770: Update smtp.send_message to use email.message.as_bytes() #18061

Open
wants to merge 1 commit into
base: master
from
Open

bpo-19770: Update smtp.send_message to use email.message.as_bytes() #18061

wants to merge 1 commit into from
+6 −10

Conversation

@corona10
Copy link
Member

corona10 commented Jan 19, 2020 •
edited by bedevere-bot

While I am reading bpo-19770,
I've noticed that current logic can be replaced by email.message.as_bytes().
it can reduce maintenance effort about message flattening logic.

But at some point, this can be the code churn.
If you feel that this is code churn, we can reject this PR

https://bugs.python.org/issue19770
@corona10 corona10 requested a review from python/email-team as a code owner Jan 19, 2020
@corona10 corona10 added the skip news label Jan 19, 2020
@corona10 corona10 requested review from vstinner and csabella Jan 19, 2020
@corona10 corona10 force-pushed the corona10:bpo-19770-smtp branch from 8ffe206 to a259223 Jan 19, 2020
@corona10
bpo-19770: Update smtp.send_message to use email.message.as_bytes()
Loading status checks…
98467cb
@corona10 corona10 force-pushed the corona10:bpo-19770-smtp branch from eface89 to 98467cb Jan 19, 2020
@csabella csabella removed their request for review Jan 19, 2020
@vstinner vstinner removed their request for review Jan 19, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 19, 2020

@warsaw, @bitdancer, @maxking: Would you mind to review this PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/email-team email-team

Assignees
No one assigned
Labels
CLA signed awaiting review skip news
Projects
None yet
Milestone
No milestone
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.