Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39305: Refactor nntplib.py #18045

Open
wants to merge 2 commits into
base: master
from
Open

bpo-39305: Refactor nntplib.py #18045

wants to merge 2 commits into from
+48 −62

Conversation

@LucianaMarques
Copy link

LucianaMarques commented Jan 17, 2020 •
edited by bedevere-bot

  • Join two classes (NNTP and _NNTPBase)
  • Modify one test accordingly

https://bugs.python.org/issue39305
@LucianaMarques
bpo-39305: Refactor nntplib.py
Loading status checks…
fb4d85f 
* Join two classes (NNTP and _NNTPBase)
* Modify one test accordingly
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6818b2a
@LucianaMarques

This comment has been minimized.

Sign in to view
Copy link
Author

LucianaMarques commented Jan 17, 2020 •
edited

@corona10 and @vstinner this PR is in reference of bpo-39305, could you please take a look when you have a chance?

Thanks :)
@LucianaMarques LucianaMarques mentioned this pull request Jan 17, 2020
Open
@csabella csabella requested review from corona10 and vstinner Jan 18, 2020
@corona10
corona10 suggested changes Jan 18, 2020
View changes
Lib/nntplib.py
@@ -310,8 +309,9 @@ class _NNTPBase:
encoding = 'utf-8'
errors = 'surrogateescape'

def __init__(self, file, host,
readermode=None, timeout=_GLOBAL_DEFAULT_TIMEOUT):
def __init__(self, host, file=None,

This comment has been minimized.

Sign in to view
Copy link
@corona10

corona10 Jan 18, 2020

Member

I don't want to add a new parameter file for NNTP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@LucianaMarques @corona10 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.