Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39383: Mention Darwin as a potential value for platform.system() #18054

Merged
merged 1 commit into from Jan 20, 2020
Merged

bpo-39383: Mention Darwin as a potential value for platform.system() #18054

merged 1 commit into from Jan 20, 2020

Conversation

@bittner
Copy link
Contributor

bittner commented Jan 18, 2020 •
edited by bedevere-bot

This change mentions 'Darwin' as a possible value for

platform.system()

in the documentation of the platform module.

https://bugs.python.org/issue39383
@bittner bittner changed the title Mention Darwin as a potential value for platform.system() bpo-39383: Mention Darwin as a potential value for platform.system() Jan 18, 2020
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor

csabella commented Jan 18, 2020

I think this is a great suggestion, but I don't think you need the parenthetical for macOS.
@ned-deily
ned-deily requested changes Jan 18, 2020
View changes
Doc/library/platform.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 18, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@bittner
Mention Darwin as a potential value for platform.system()
Loading status checks…
cc3ee08
@bittner bittner force-pushed the bittner:docs/mention-macos-platform-system branch from a8fb1bb to cc3ee08 Jan 19, 2020
@bittner

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bittner commented Jan 19, 2020

I have made the requested changes; please review again.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 19, 2020

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from ned-deily Jan 19, 2020
@ned-deily
ned-deily approved these changes Jan 20, 2020
View changes
Copy link
Member

ned-deily left a comment

LGTM, thanks!
@ned-deily ned-deily merged commit 8d57a41 into python:master Jan 20, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200119.25 succeeded
Details
bedevere/issue-number Issue number 39383 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 20, 2020

Thanks @bittner for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 20, 2020
@bittner @miss-islington
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
d86bb80 
…ythonGH-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <django@bittner.it>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 20, 2020

GH-18088 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 20, 2020
@bittner @miss-islington
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
4fc53b9 
…ythonGH-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <django@bittner.it>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 20, 2020

GH-18089 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 20, 2020
@miss-islington @bittner
bpo-39383: Mention Darwin as a potential value for platform.system() (G…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3da8390 
…H-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <django@bittner.it>
miss-islington added a commit that referenced this pull request Jan 20, 2020
@miss-islington @bittner
bpo-39383: Mention Darwin as a potential value for platform.system() (G…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1964e0 
…H-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <django@bittner.it>
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@bittner @petdance
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
b6c5ea3 
…ythonGH-18054)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@bittner @petdance
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
2cec492 
…ythonGH-18054)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@bittner @petdance
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
9d35182 
…ythonGH-18054)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@bittner @petdance
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
e7c117e 
…ythonGH-18054)
@bittner bittner deleted the bittner:docs/mention-macos-platform-system branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@bittner @csabella @bedevere-bot @miss-islington @ned-deily @the-knights-who-say-ni
You can’t perform that action at this time.