Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base to based in webbrowser.py (typo) #18055

Merged
merged 1 commit into from Jan 19, 2020
Merged

Fix base to based in webbrowser.py (typo) #18055

merged 1 commit into from Jan 19, 2020
+1 −1

Conversation

@micha2718l
Copy link
Contributor

micha2718l commented Jan 18, 2020

This PR fixes a typo in the docstring in webbrowser.py
base -> based
@micha2718l
fix base to based
Loading status checks…
2c564c6
@micha2718l micha2718l changed the title Fix base to based in webbrowser.py Fix base to based in webbrowser.py (typo) Jan 18, 2020
@corona10
corona10 approved these changes Jan 19, 2020
View changes
@csabella
csabella approved these changes Jan 19, 2020
View changes
Copy link
Contributor

csabella left a comment

LGTM. Thank you for the change!
@csabella csabella merged commit 558f078 into python:master Jan 19, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200118.38 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 19, 2020

Thanks @micha2718l for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 19, 2020
@micha2718l @miss-islington
Fix typo from base to based (pythonGH-18055)
120669e 
(cherry picked from commit 558f078)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 19, 2020

GH-18063 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 19, 2020
@micha2718l @miss-islington
Fix typo from base to based (pythonGH-18055)
dac2b10 
(cherry picked from commit 558f078)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 19, 2020

GH-18064 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 19, 2020
@miss-islington @micha2718l
Fix typo from base to based (GH-18055)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c7b16f8 
(cherry picked from commit 558f078)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
miss-islington added a commit that referenced this pull request Jan 19, 2020
@miss-islington @micha2718l
Fix typo from base to based (GH-18055)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d96b7dd 
(cherry picked from commit 558f078)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 19, 2020
@sthagen
Merge pull request #191 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
99192be 
Fix typo from base to based (pythonGH-18055)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@micha2718l @petdance
Fix typo from base to based (pythonGH-18055)
303c40d
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@micha2718l @petdance
Fix typo from base to based (pythonGH-18055)
92b9009
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@micha2718l @petdance
Fix typo from base to based (pythonGH-18055)
cf7dcf2
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@micha2718l @petdance
Fix typo from base to based (pythonGH-18055)
68c259a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@csabella csabella

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@micha2718l @miss-islington @bedevere-bot @corona10 @csabella @the-knights-who-say-ni
You can’t perform that action at this time.