Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35182: fix communicate() crash after child closes its pipes #18117

Open
wants to merge 1 commit into
base: master
from
Open

bpo-35182: fix communicate() crash after child closes its pipes #18117

wants to merge 1 commit into from
+16 −2

Conversation

@alpire
Copy link

alpire commented Jan 22, 2020 •
edited

When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running. The fix is trivial.

(Original PR is #17020. I had to create a new one to rebase on top of master & fix merge conflicts)

https://bugs.python.org/issue35182
@and800 @alpire
bpo-35182: fix communicate() crash after child closes its pipes (GH-1…
Loading status checks…
35fd4c9 
…7020)

When communicate() is called in a loop, it crashes when the child process
has already closed any piped standard stream, but still continues to be running
@alpire alpire requested a review from gpshead as a code owner Jan 22, 2020
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 22, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@alpire

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@alpire alpire mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
4 participants
@alpire @the-knights-who-say-ni @bedevere-bot @and800
You can’t perform that action at this time.