Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-21063: Improve module synopsis #17363

Merged
merged 2 commits into from Nov 25, 2019
Merged

bpo-21063: Improve module synopsis #17363

merged 2 commits into from Nov 25, 2019
+9 −9

Conversation

@GeniusLearner
Copy link
Contributor

GeniusLearner commented Nov 23, 2019 •
edited by bedevere-bot

Cleanup synopsis of modules in documentation.

https://bugs.python.org/issue21063
@GeniusLearner
bpo-21063: Improve module synopsis
Loading status checks…
f8165e2
@CuriousLearner
CuriousLearner reviewed Nov 23, 2019
View changes
Copy link
Contributor

CuriousLearner left a comment

I've one question mentioned inline. Rest everything looks good to me.
Doc/distutils/apiref.rst Show resolved Hide resolved
@brettcannon brettcannon self-requested a review Nov 25, 2019
@brettcannon
brettcannon requested changes Nov 25, 2019
View changes
Copy link
Member

brettcannon left a comment

One minor improvement to (try to) make. Otherwise LGTM!
Doc/distutils/apiref.rst Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 25, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@GeniusLearner @brettcannon
Update Doc/distutils/apiref.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2976f2a 
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
@GeniusLearner

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

GeniusLearner commented Nov 25, 2019

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 25, 2019

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from brettcannon Nov 25, 2019
@CuriousLearner
CuriousLearner approved these changes Nov 25, 2019
View changes
Copy link
Contributor

CuriousLearner left a comment

LGTM 🌮
@CuriousLearner

This comment has been minimized.

Sign in to view
Copy link
Contributor

CuriousLearner commented Nov 25, 2019

Hey @GeniusLearner

Since this is your first contribution, you can put your name in https://github.com/python/cpython/blob/master/Misc/ACKS file which contains list of contributors to the repo, if you prefer.
@eamanu
eamanu approved these changes Nov 25, 2019
View changes
Copy link
Contributor

eamanu left a comment

LGTM.
@brettcannon
brettcannon approved these changes Nov 25, 2019
View changes
@brettcannon brettcannon merged commit f8a6316 into python:master Nov 25, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191125.15 succeeded
Details
bedevere/issue-number Issue number 21063 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 25, 2019

GH-17381 is a backport of this pull request to the 3.7 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 25, 2019

GH-17382 is a backport of this pull request to the 3.6 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

Sorry, @GeniusLearner and @brettcannon, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 2.7
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
81c6731 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
75ba9e1 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

Sorry @GeniusLearner and @brettcannon, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 3.8
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 25, 2019

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
32a5a69 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 25, 2019

GH-17383 is a backport of this pull request to the 3.8 branch.
@brettcannon

This comment has been minimized.

Sign in to view
Copy link
Member

brettcannon commented Nov 25, 2019

@GeniusLearner thanks for the PR (and everyone else for the PR review)!
miss-islington added a commit that referenced this pull request Nov 25, 2019
@miss-islington @GeniusLearner
bpo-21063: Improve module synopsis for distutils (GH-17363)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
089387e 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>
brettcannon added a commit that referenced this pull request Nov 26, 2019
@miss-islington @GeniusLearner @brettcannon
bpo-21063: Improve module synopsis for distutils (GH-17363) (#17381)
Loading status checks…
2f24893 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <54467174+GeniusLearner@users.noreply.github.com>
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@GeniusLearner @jacobneiltaylor
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
1913b11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@eamanu eamanu

@CuriousLearner CuriousLearner

Assignees

@brettcannon brettcannon

Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
7 participants
@GeniusLearner @bedevere-bot @CuriousLearner @miss-islington @brettcannon @eamanu @the-knights-who-say-ni
You can’t perform that action at this time.