Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37883 - Added a new method doc to threading.Lock().locked() #17427

Merged
merged 1 commit into from Dec 1, 2019
Merged

bpo-37883 - Added a new method doc to threading.Lock().locked() #17427

merged 1 commit into from Dec 1, 2019

Conversation

@idomic
Copy link
Contributor

idomic commented Dec 1, 2019 •
edited

https://bugs.python.org/issue37883
@idomic
Created new PR with correct user
Loading status checks…
628539d
@idomic

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

idomic commented Dec 1, 2019

Adding @taleinat, I'm also closing the old PR.
@idomic idomic mentioned this pull request Dec 1, 2019
Closed
@idomic

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

idomic commented Dec 1, 2019

How can I add the skip news label? do I have permissions for that?
@taleinat taleinat added the skip news label Dec 1, 2019
@taleinat

This comment has been minimized.

Sign in to view
Copy link
Contributor

taleinat commented Dec 1, 2019 •
edited

How can I add the skip news label? do I have permissions for that?

@idomic, no, one needs special permissions in order to change labels.
@taleinat
taleinat approved these changes Dec 1, 2019
View changes
Copy link
Contributor

taleinat left a comment

LGTM
@taleinat taleinat merged commit fdafa1d into python:master Dec 1, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191201.15 succeeded
Details
bedevere/issue-number Issue number 37883 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 1, 2019

Thanks @idomic for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@idomic @miss-islington
document threading.Lock.locked() (pythonGH-17427)
76b004a 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

GH-17428 is a backport of this pull request to the 3.8 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

GH-17429 is a backport of this pull request to the 3.7 branch.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 1, 2019

GH-17430 is a backport of this pull request to the 2.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@idomic @miss-islington
document threading.Lock.locked() (pythonGH-17427)
426d877 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
@idomic @miss-islington
document threading.Lock.locked() (pythonGH-17427)
7e5ce3a 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @idomic
document threading.Lock.locked() (GH-17427)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8642071 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @idomic
document threading.Lock.locked() (GH-17427)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cbac6ee 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
@miss-islington @idomic
document threading.Lock.locked() (GH-17427)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d300c0e 
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
@taleinat

This comment has been minimized.

Sign in to view
Copy link
Contributor

taleinat commented Dec 1, 2019

Congratulations on your first contribution to CPython, @idomic! 🍾
@idomic

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

idomic commented Dec 1, 2019

Thanks for the quick response and help along the way 💯 :)
@idomic idomic deleted the idomic:DocFix branch Dec 1, 2019
stealthcopter added a commit to stealthcopter/cpython that referenced this pull request Dec 3, 2019
@stealthcopter
Merge pull request #1 from python/2.7
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
63e7cf8 
document threading.Lock.locked() (pythonGH-17427)
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@idomic @jacobneiltaylor
document threading.Lock.locked() (pythonGH-17427)
e44c426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@idomic @taleinat @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.