Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-17005: Add a topological sort algorithm #11583
Conversation
9048fbb
to
bc0512c
I'm not sure if API design should happen here or back on the issue, but I'll start with here. |
This comment has been minimized.
This comment has been minimized.
@rhettinger Could you advise about the API of this function? I think the new API is more convenient but a bit less powerful, but I am waiting for your input on this matter to continue development/discussion :) |
This comment has been minimized.
This comment has been minimized.
Just to make it simpler to evaluate. The equivalent input for:
would be:
and the result is:
representing that you can choose an arbitrary order in every group and that satisfies the sorting. |
Minor spelling, mechanics, and clarity in docs. |
Co-Authored-By: sweeneyde <36520290+sweeneyde@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
@tim-one @larryhastings The PR has been still for a while and I think is close to being ready for a first merge. I would like to get this in before the 3rd alpha so there is plenty of time to test this and still have possibilities to change things. Do you have any changes to the API that you would like to be changed? What about Larry's paint cans? Improvement to the docs can be made later as this can always be modified freely after the feature freeze :) |
Ship it! |
This comment has been minimized.
This comment has been minimized.
Now that the Thank you very much to everyone involved in this issue, the discussions and for all the patience with reviews and iterations (thanks to @tim-one especially |
99e6c26
into
python:master
pablogsal commentedJan 17, 2019
•
edited
https://bugs.python.org/issue17005