Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39350: Remove deprecated fractions.gcd() #18021
Merged
Conversation
Lib/fractions.py
Outdated
| @@ -13,28 +13,6 @@ | |||
| __all__ = ['Fraction', 'gcd'] | |||
This comment has been minimized.
This comment has been minimized.
serhiy-storchaka
Jan 16, 2020
Member
Suggested change
| __all__ = ['Fraction', 'gcd'] | |
| __all__ = ['Fraction'] |
This comment has been minimized.
This comment has been minimized.
vstinner
Jan 16, 2020
Author
Member
Oops, good catch! fixed. I also rebased my PR to fix a conflict.
vstinner
merged commit 4691a2f
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Remove fractions.gcd() function, deprecated since Python 3.5 (bpo-22486): use math.gcd() instead.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Remove fractions.gcd() function, deprecated since Python 3.5 (bpo-22486): use math.gcd() instead.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
Remove fractions.gcd() function, deprecated since Python 3.5 (bpo-22486): use math.gcd() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 16, 2020
•
edited by bedevere-bot
Remove fractions.gcd() function, deprecated since Python 3.5
(bpo-22486): use math.gcd() instead.
https://bugs.python.org/issue39350