Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39352: Remove the formatter module #18023

Open
wants to merge 1 commit into
base: master
from
Open

bpo-39352: Remove the formatter module #18023

wants to merge 1 commit into from
+7 −818

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 16, 2020 •
edited by bedevere-bot

Remove the formatter module. It was deprecated since Python 3.4 and
was not tested.

https://bugs.python.org/issue39352
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 16, 2020

cc @brettcannon @tiran
@corona10

This comment has been minimized.

Sign in to view
Copy link
Member

corona10 commented Jan 16, 2020

@vstinner
https://github.com/python/cpython/blob/188ebfa475a6f6aa2d0ea14ca8e1fbe7865b6d27/Doc/library/misc.rst#miscellaneous-services reference formatter module.
@vstinner vstinner force-pushed the vstinner:remove_formatter branch from cd1e425 to 9d6e52c Jan 16, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 16, 2020

@vstinner
https://github.com/python/cpython/blob/188ebfa475a6f6aa2d0ea14ca8e1fbe7865b6d27/Doc/library/misc.rst#miscellaneous-services reference formatter module.

Oh right, fixed. I also rebased my PR to fix a merge conflict.
@corona10
corona10 approved these changes Jan 16, 2020
View changes
Copy link
Member

corona10 left a comment

LGTM, good bye formatter
@vstinner
bpo-39352: Remove the formatter module
Loading status checks…
2209d5e 
Remove the formatter module. It was deprecated since Python 3.4 and
was not tested.
@vstinner vstinner force-pushed the vstinner:remove_formatter branch from 9d6e52c to 2209d5e Jan 16, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 16, 2020

PR rebased to fix the conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @corona10 @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.