Skip to content

[2.7] bpo-35182: fix communicate() crash after child closes its pipes (GH-17020) #17023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[2.7] bpo-35182: fix communicate() crash after child closes its pipes (GH-17020) #17023

wants to merge 1 commit into from

Conversation

and800
Copy link
Contributor

@and800 and800 commented Oct 31, 2019 •
edited
Loading

invalid port
haven't noticed that there's no timeout feature in py2

@and800
[2.7] bpo-35182: fix communicate() crash after child closes its pipes (…
66c1e1a 
…GH-17020)

When communicate() is called in a loop, it crashes when the child process
has already closed any piped standard stream, but still continues to be running
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 31, 2019
@and800 and800 closed this Nov 1, 2019
@and800 and800 deleted the subprocess27 branch November 1, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@and800 @the-knights-who-say-ni @bedevere-bot