Skip to content

[3.8] bpo-38738: Fix formatting of True and False. (GH-17083) #17125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2019
Merged

[3.8] bpo-38738: Fix formatting of True and False. (GH-17083) #17125

merged 1 commit into from
Nov 12, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 12, 2019 •
edited by bedevere-bot
Loading

  • "Return true/false" is replaced with "Return ``True``/``False``"
    if the function actually returns a bool.
  • Fixed formatting of some True and False literals (now in monospace).
  • Replaced "True/False" with "true/false" if it can be not only bool.
  • Replaced some 1/0 with True/False if it corresponds the code.
  • "Returns " is replaced with "Return ".
    (cherry picked from commit 138ccbb)

https://bugs.python.org/issue38738

@bedevere-bot bedevere-bot mentioned this pull request Nov 12, 2019
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting core review labels Nov 12, 2019
@serhiy-storchaka
[3.8] bpo-38738: Fix formatting of True and False. (pythonGH-17083)
49f6a9e 
* "Return true/false" is replaced with "Return ``True``/``False``"
  if the function actually returns a bool.
* Fixed formatting of some True and False literals (now in monospace).
* Replaced "True/False" with "true/false" if it can be not only bool.
* Replaced some 1/0 with True/False if it corresponds the code.
* "Returns <bool>" is replaced with "Return <bool>"..
(cherry picked from commit 138ccbb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit d360346 into python:3.8 Nov 12, 2019
@serhiy-storchaka serhiy-storchaka deleted the backport-138ccbb-3.8 branch November 12, 2019 16:54
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d360346640e19231032b072216195484fa2450b4 3.7

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @the-knights-who-say-ni @bedevere-bot