Skip to content

bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_unix #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_unix #17294

merged 1 commit into from
Nov 20, 2019

Conversation

xdegaye
Copy link
Contributor

@xdegaye xdegaye commented Nov 20, 2019 •
edited by miss-islington
Loading

on platforms lacking a functional bind() for named unix domain sockets

https://bugs.python.org/issue38841

Automerge-Triggered-By: @asvetlov

@xdegaye
bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_unix
b75962f 
on platforms lacking a functional bind() for named unix domain sockets
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 20, 2019
corona10
corona10 reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, test_create_datagram_endpoint_sock_unix can be applied also?

@xdegaye
Copy link
Contributor Author

xdegaye commented Nov 20, 2019

@corona10
can you please elaborate

@corona10
Copy link
Member

corona10 commented Nov 20, 2019 •
edited
Loading

can you please elaborate

Oh.. sorry please ignore my previous comment. :(
My understanding was wrong The patch seems right.
(I re-read https://bugs.python.org/issue38841)

@miss-islington miss-islington merged commit 559bad1 into python:master Nov 20, 2019
@miss-islington
Copy link
Contributor

Thanks @xdegaye for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17299 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @xdegaye, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 559bad1a70ed50cc9caa7cb303b6ac1fe6a34af3 3.7

@miss-islington miss-islington self-assigned this Nov 20, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
@xdegaye @miss-islington
bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_u…
7304a2e 
…nix (pythonGH-17294)

on platforms lacking a functional bind() for named unix domain sockets

https://bugs.python.org/issue38841

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 559bad1)

Co-authored-by: xdegaye <xdegaye@gmail.com>
@asvetlov
Copy link
Contributor

I don't want backporting to to 3.7.

@xdegaye if you do care please make a PR.
If not -- the version can live as is I guess.

@xdegaye
Copy link
Contributor Author

xdegaye commented Nov 20, 2019

@asvetlov
It is a failing test on a non fully supported platform, so I agree that backporting to 3.7 is not necessary. I will close the issue.
Thanks for merging the PR Andrew.

@xdegaye xdegaye deleted the bpo-38841 branch November 20, 2019 20:17
miss-islington added a commit that referenced this pull request Nov 20, 2019
@miss-islington @xdegaye
bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_u…
b762375 
…nix (GH-17294)

on platforms lacking a functional bind() for named unix domain sockets

https://bugs.python.org/issue38841

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 559bad1)

Co-authored-by: xdegaye <xdegaye@gmail.com>
@sthagen sthagen mentioned this pull request Nov 20, 2019
Merged
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@xdegaye
bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_u…
a5f82e2 
…nix (pythonGH-17294)

on platforms lacking a functional bind() for named unix domain sockets



https://bugs.python.org/issue38841



Automerge-Triggered-By: @asvetlov
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@xdegaye @shihai1991
bpo-38841: Skip asyncio test_create_datagram_endpoint_existing_sock_u…
b837fc0 
…nix (pythonGH-17294)

on platforms lacking a functional bind() for named unix domain sockets



https://bugs.python.org/issue38841



Automerge-Triggered-By: @asvetlov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@corona10 corona10 corona10 approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@miss-islington miss-islington

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xdegaye @corona10 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni