Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fixed the parameter list of object. _rpow_ in the document #16477

Merged
merged 1 commit into from Jan 5, 2020
Merged

Doc: Fixed the parameter list of object. _rpow_ in the document #16477

merged 1 commit into from Jan 5, 2020

Conversation

@hongweipeng
Copy link
Contributor

hongweipeng commented Sep 29, 2019

The parameter list of object.__rpow__ should be the same as object.__pow__. As described in typeobject.c:

    NBSLOT("__pow__", nb_power, slot_nb_power, wrap_ternaryfunc,
           "__pow__($self, value, mod=None, /)\n--\n\nReturn pow(self, value, mod)."),
    NBSLOT("__rpow__", nb_power, slot_nb_power, wrap_ternaryfunc_r,
           "__rpow__($self, value, mod=None, /)\n--\n\nReturn pow(value, self, mod)."),
@hongweipeng
Fixed the parameter list of object. _rpow_ in the document
Loading status checks…
3fe56ec
@brandtbucher
brandtbucher approved these changes Sep 29, 2019
View changes
@csabella csabella merged commit abc0c4f into python:master Jan 5, 2020
4 checks passed
4 checks passed
Azure Pipelines PR #20190929.14 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 5, 2020

Thanks @hongweipeng for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@hongweipeng @miss-islington
Fix the parameter list of object. _rpow_ (GH-pythonGH-16477)
9455f39 
(cherry picked from commit abc0c4f)

Co-authored-by: HongWeipeng <961365124@qq.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @hongweipeng
Fix the parameter list of object. _rpow_ (GH-GH-16477)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b853a7c 
(cherry picked from commit abc0c4f)

Co-authored-by: HongWeipeng <961365124@qq.com>
miss-islington added a commit that referenced this pull request Jan 5, 2020
@miss-islington @hongweipeng
Fix the parameter list of object. _rpow_ (GH-GH-16477)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cfeacf2 
(cherry picked from commit abc0c4f)

Co-authored-by: HongWeipeng <961365124@qq.com>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Jan 8, 2020
@hongweipeng @gousaiyang
Fix the parameter list of object. _rpow_ (#pythonGH-16477)
2a38d12
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@hongweipeng @petdance
Fix the parameter list of object. _rpow_ (#pythonGH-16477)
a5bed0c
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@hongweipeng @petdance
Fix the parameter list of object. _rpow_ (#pythonGH-16477)
a3c2211
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@hongweipeng @petdance
Fix the parameter list of object. _rpow_ (#pythonGH-16477)
3310a3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
CLA signed needs backport to 3.7 needs backport to 3.8 skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@hongweipeng @miss-islington @brandtbucher @the-knights-who-say-ni @csabella @bedevere-bot
You can’t perform that action at this time.