Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38524: clarify example a bit and improve formatting #17406
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Nov 28, 2019
|
Thanks @taleinat for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Nov 28, 2019
|
GH-17411 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Nov 28, 2019
|
GH-17412 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2019
miss-islington
added a commit
that referenced
this pull request
Nov 28, 2019
miss-islington
added a commit
that referenced
this pull request
Nov 28, 2019
jacobneiltaylor
added a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
taleinat commentedNov 27, 2019
•
edited by bedevere-bot
After merging PR GH-17364, I noticed that
__set_name__andtypewere not formatted as references, and that the code example could use a bit more context for clarity.CC @DahlitzFlorian
https://bugs.python.org/issue38524