bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437

torsava · 2019-12-02T15:54:08Z

Make ssl tests less strict and also accept TLSv3 as the default maximum
version. This change unbreaks test_min_max_version on Fedora 32.

https://bugs.python.org/issue38815

Automerge-Triggered-By: @tiran


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN)

Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32.

torsava · 2019-12-02T15:54:50Z

I believe this is not worth a news entry, but I can provide it if required.

pablogsal · 2019-12-02T16:04:55Z

Once the CI passes here I will test this on the buildbots :)

miss-islington · 2019-12-02T16:15:46Z

Thanks @torsava for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

pablogsal · 2019-12-02T16:16:04Z

Testing happening here:

https://buildbot.python.org/all/#/builders?tags=%2Bstable&tags=%2Bcustom


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (pythonGH-1…

…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>

bedevere-bot · 2019-12-02T16:16:11Z

GH-17438 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2019-12-02T16:16:18Z

GH-17439 is a backport of this pull request to the 3.7 branch.


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (pythonGH-1…

…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (GH-17437)

Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (GH-17437)

Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>


        Merge pull request #60 from python/master

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (pythonGH-17437)

hroncok · 2019-12-02T17:27:25Z

Thank you @torsava 🎉

BTW Am I the only one who notices the "GH-NNNN" in the title and commit message?

torsava · 2019-12-02T17:43:39Z

Thank you @torsava

BTW Am I the only one who notices the "GH-NNNN" in the title and commit message?

You're not. The guide says to put the NNNN there (because at that point there's no number) and that it's going to be replaced by the actual number upon merge. Apparently not. I'm confused.

pablogsal · 2019-12-02T17:45:53Z

You're not. The guide says to put the NNNN there (because at that point there's no number) and that it's going to be replaced by the actual number upon merge. Apparently not. I'm confused

The PR title itself should not need the (GH-NNNN) part but the core developer that merges is the one that should add it (when clicking the merge button it adds already a similar suffix and we need to change some letters to GH). In general, you can skip it for future PRs ;)

torsava · 2019-12-02T17:48:42Z

The PR title itself should not need the (GH-NNNN) part but the core developer that merges is the one that should add it (when clicking the merge button it adds already a similar suffix and we need to change some letters to GH). In general, you can skip it for future PRs ;)

Good to know, thanks!

bedevere-bot · 2019-12-02T19:44:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.x has failed when building commit 34864d1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/150/builds/6) and take a look at the build logs.
Check if the failure is related to this commit (34864d1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/150/builds/6

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 5, done.        
remote: Counting objects:  20% (1/5)        
remote: Counting objects:  40% (2/5)        
remote: Counting objects:  60% (3/5)        
remote: Counting objects:  80% (4/5)        
remote: Counting objects: 100% (5/5)        
remote: Counting objects: 100% (5/5), done.        
remote: Total 5 (delta 4), reused 4 (delta 4), pack-reused 0        
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.

test_gdb skipped -- Couldn't find gdb on the path
test_poll skipped -- select.poll not defined
test_syslog skipped -- No module named 'syslog'
test_wait4 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
test_fcntl skipped -- No module named 'fcntl'
test_dbm_gnu skipped -- No module named '_gdbm'
test_wait3 skipped -- os.fork not defined
test_resource skipped -- No module named 'resource'
test_pwd skipped -- No module named 'pwd'
stty: standard input: Inappropriate ioctl for device
test_openpty skipped -- os.openpty() not available.
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_devpoll skipped -- test works only on Solaris OS family
test_xxtestfuzz skipped -- No module named '_xxtestfuzz'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_grp skipped -- No module named 'grp'
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_nis skipped -- No module named 'nis'
test_epoll skipped -- test works only on Linux 2.6
test_multiprocessing_forkserver skipped -- forkserver is not available on Windows
test_pipes skipped -- pipes module only works on posix
test_fork1 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
test_posix skipped -- No module named 'posix'
test_spwd skipped -- No module named 'spwd'
test_ossaudiodev skipped -- No module named 'ossaudiodev'
test_readline skipped -- No module named 'readline'
test_dbm_ndbm skipped -- No module named '_dbm'
test_threadsignals skipped -- Can't test signal on win32
test_multiprocessing_fork skipped -- fork is not available on Windows
test_ioctl skipped -- No module named 'fcntl'
test_kqueue skipped -- test works only on BSD
test_pty skipped -- No module named 'termios'
test_curses skipped -- No module named '_curses'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip


        bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (pythonGH-1…

…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN)

Loading status checks…

04bc8cd

Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32.

torsava requested a review from tiran as a code owner Dec 2, 2019

the-knights-who-say-ni added the CLA signed label Dec 2, 2019

bedevere-bot added type-tests awaiting review labels Dec 2, 2019

pablogsal added the skip news label Dec 2, 2019

pablogsal self-requested a review Dec 2, 2019

pablogsal self-assigned this Dec 2, 2019

tiran approved these changes Dec 2, 2019

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Dec 2, 2019

tiran added needs backport to 3.7 needs backport to 3.8 🤖 automerge labels Dec 2, 2019

bedevere-bot removed the awaiting merge label Dec 2, 2019

bedevere-bot removed the needs backport to 3.8 label Dec 2, 2019

bedevere-bot removed the needs backport to 3.7 label Dec 2, 2019

python/cpython

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437

torsava commented Dec 2, 2019 •

edited by miss-islington

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

hroncok commented Dec 2, 2019

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

Sponsor python/cpython

python/cpython

Join GitHub today

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437

bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437

Conversation

torsava commented Dec 2, 2019 • edited by miss-islington

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

hroncok commented Dec 2, 2019

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

pablogsal commented Dec 2, 2019

This comment has been minimized.

torsava commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

torsava commented Dec 2, 2019 •

edited by miss-islington