Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33488: Satisfy markdownlint for pull request #6786

Merged
merged 1 commit into from May 14, 2018

Conversation

grimreaper
Copy link
Contributor

@grimreaper grimreaper commented May 14, 2018

skip news
markdownlint is, as the name implies, a tool for linting markdown files. The current template has several warnings. Fix them.

https://bugs.python.org/issue33488

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines
@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2018

Thanks @grimreaper for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2018

Sorry, @grimreaper and @benjaminp, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5cd22cf2097a6dd209999cf97858d54564a3be87 3.7

@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2018

Sorry, @grimreaper and @benjaminp, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5cd22cf2097a6dd209999cf97858d54564a3be87 3.6

benjaminp pushed a commit that referenced this pull request May 14, 2018
…H-6786)

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines.
(cherry picked from commit 5cd22cf)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 14, 2018

GH-6787 is a backport of this pull request to the 3.7 branch.

benjaminp added a commit that referenced this pull request May 14, 2018
…H-6786)

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines.
(cherry picked from commit 5cd22cf)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
@grimreaper grimreaper deleted the eax/mdl/mdl_fix_template_fix branch May 15, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
…nGH-6786)

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants