Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38610: Fix possible crashes in several list methods #17022

Merged
merged 3 commits into from Dec 30, 2019
Merged

bpo-38610: Fix possible crashes in several list methods #17022

merged 3 commits into from Dec 30, 2019
+40 −3

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Oct 31, 2019 •
edited by bedevere-bot

Hold strong references to list elements while calling
PyObject_RichCompareBool().

https://bugs.python.org/issue38610
@ZackerySpytz
bpo-38610: Fix possible crashes in several list methods
Loading status checks…
a4493c4 
Hold strong references to list elements while calling
PyObject_RichCompareBool().
@shihai1991
shihai1991 reviewed Nov 3, 2019
View changes
Objects/listobject.c Show resolved Hide resolved
@ZackerySpytz ZackerySpytz mentioned this pull request Dec 30, 2019
Merged
@pablogsal
pablogsal approved these changes Dec 30, 2019
View changes
Copy link
Member

pablogsal left a comment

LGTM
Lib/test/test_list.py Outdated Show resolved Hide resolved
@ZackerySpytz
Merge remote-tracking branch 'upstream/master' into bpo-38610-list-me…
e5c09a2 
…thod-crashes
@ZackerySpytz
Add the issue number to the test comment.
Loading status checks…
5090ae2
@pablogsal pablogsal merged commit d9e561d into python:master Dec 30, 2019
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191230.12 succeeded
Details
bedevere/issue-number Issue number 38610 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 30, 2019

Thanks @ZackerySpytz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@pablogsal

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 30, 2019

Thanks @ZackerySpytz for the quick fix!
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 30, 2019

GH-17758 is a backport of this pull request to the 3.8 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 30, 2019

Sorry, @ZackerySpytz and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d9e561d23d994e3ed15f4fcbd7ee5c8fe50f190b 3.7
pablogsal added a commit to pablogsal/cpython that referenced this pull request Dec 30, 2019
@ZackerySpytz @pablogsal
[3.7] bpo-38610: Fix possible crashes in several list methods (python…
Verified
This commit was signed with a verified signature.
pablogsal Pablo Galindo
GPG key ID: FFE87404168BD847 Learn about signing commits
f8679b1 
…GH-17022)

Hold strong references to list elements while calling PyObject_RichCompareBool()..
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 30, 2019

GH-17759 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Dec 30, 2019
@miss-islington @ZackerySpytz
bpo-38610: Fix possible crashes in several list methods (GH-17022)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fcaf14c 
Hold strong references to list elements while calling PyObject_RichCompareBool().
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
pablogsal added a commit that referenced this pull request Dec 30, 2019
@pablogsal @ZackerySpytz
[3.7] bpo-38610: Fix possible crashes in several list methods (GH-17022…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
296d45e 
…) (GH-17759)

Hold strong references to list elements while calling PyObject_RichCompareBool()..
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
petdance added a commit to petdance/cpython that referenced this pull request Jan 9, 2020
@ZackerySpytz @petdance
bpo-38610: Fix possible crashes in several list methods (pythonGH-17022)
5e6306a 
Hold strong references to list elements while calling PyObject_RichCompareBool().
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@ZackerySpytz @petdance
bpo-38610: Fix possible crashes in several list methods (pythonGH-17022)
c2d4edc 
Hold strong references to list elements while calling PyObject_RichCompareBool().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@ZackerySpytz @miss-islington @pablogsal @bedevere-bot @shihai1991 @the-knights-who-say-ni
You can’t perform that action at this time.