Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Lib/socketserver.py docstring #17024

Merged
merged 1 commit into from Nov 16, 2019
Merged

Fix typo in Lib/socketserver.py docstring #17024

merged 1 commit into from Nov 16, 2019

Conversation

YesmynameisPerry
Copy link
Contributor

@YesmynameisPerry YesmynameisPerry commented Nov 1, 2019

Changed:

'This is bad class design, but save some typing'

Into:

'This is bad class design, but saves some typing'

@YesmynameisPerry
fix typo in Lib/socketserver.py
f42c2ad 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 1, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@YesmynameisPerry

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher brandtbucher added skip issue skip news docs Documentation in the Doc dir labels Nov 1, 2019
@brandtbucher
Copy link
Member

brandtbucher commented Nov 1, 2019 •
edited

Thanks for your time @YesmynameisPerry, and welcome to CPython! 😎

I assume you've seen the bot's message about the CLA?

brandtbucher
brandtbucher approved these changes Nov 1, 2019
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Nice catch!

eamanu
eamanu approved these changes Nov 1, 2019
View changes
Copy link
Contributor

@eamanu eamanu left a comment

Good Catch

@corona10 corona10 requested a review from vstinner Nov 16, 2019
corona10
corona10 approved these changes Nov 16, 2019
View changes
Copy link
Member

@corona10 corona10 left a comment

LGTM

@vstinner Can you take a look at this PR as the core developers?
It looks like just a typo so it can be easily merged.

@vstinner vstinner merged commit d0acdfc into python:master Nov 16, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @YesmynameisPerry for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2019

Thanks @YesmynameisPerry for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2019

GH-17193 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2019

GH-17194 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2019
@YesmynameisPerry @miss-islington
Fix typo in Lib/socketserver.py (pythonGH-17024)
4269b4b 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'.
(cherry picked from commit d0acdfc)

Co-authored-by: Jason (Perry) Taylor <jtaylor@seek.com.au>
@brandtbucher
Copy link
Member

brandtbucher commented Nov 16, 2019

Congrats on your first CPython contribution @YesmynameisPerry! 🍾

Looking forward to seeing more from you in the future.

@corona10
Copy link
Member

corona10 commented Nov 16, 2019

Congrat @YesmynameisPerry :)

miss-islington added a commit that referenced this pull request Nov 16, 2019
@miss-islington @YesmynameisPerry
Fix typo in Lib/socketserver.py (GH-17024)
5469bc0 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'.
(cherry picked from commit d0acdfc)

Co-authored-by: Jason (Perry) Taylor <jtaylor@seek.com.au>
miss-islington added a commit that referenced this pull request Nov 16, 2019
@miss-islington @YesmynameisPerry
Fix typo in Lib/socketserver.py (GH-17024)
e7c495e 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'.
(cherry picked from commit d0acdfc)

Co-authored-by: Jason (Perry) Taylor <jtaylor@seek.com.au>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@YesmynameisPerry
Fix typo in Lib/socketserver.py (pythonGH-17024)
8ee98be 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@YesmynameisPerry @shihai1991
Fix typo in Lib/socketserver.py (pythonGH-17024)
f966e1c 
changed 'This is bad class design, but save some typing'
into 'This is bad class design, but saves some typing'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@eamanu eamanu

@brandtbucher brandtbucher

@vstinner vstinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@YesmynameisPerry @the-knights-who-say-ni @brandtbucher @miss-islington @bedevere-bot @corona10 @eamanu @vstinner