Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Add test cases for dataclasses. (GH-17909) #17920

Merged
merged 1 commit into from Jan 10, 2020
Merged

[3.7] Add test cases for dataclasses. (GH-17909) #17920

merged 1 commit into from Jan 10, 2020
+19 −0

Conversation

@miss-islington
Copy link

miss-islington commented Jan 9, 2020 •
edited

  • Add test cases for dataclasses.

  • Add test for repr output of field.

  • Add test for ValueError to be raised when both default and default_factory are passed.
    (cherry picked from commit eef1b02)

Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com

Automerge-Triggered-By: @ericvsmith
@tirkarthi @miss-islington
Add test cases for dataclasses. (GH-17909)
Loading status checks…
1cf491b 
* Add test cases for dataclasses.

* Add test for repr output of field.
* Add test for ValueError to be raised when both default and default_factory are passed.
(cherry picked from commit eef1b02)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@miss-islington miss-islington requested a review from ericvsmith as a code owner Jan 9, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jan 9, 2020
Merged
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 9, 2020

@tirkarthi and @ericvsmith: Status check is done, and it's a success ✅ .
1 similar comment
@miss-islington

This comment has been minimized.

Sign in to view
Copy link
Author

miss-islington commented Jan 9, 2020

@tirkarthi and @ericvsmith: Status check is done, and it's a success ✅ .
@csabella
csabella approved these changes Jan 10, 2020
View changes
@miss-islington miss-islington merged commit a993658 into python:3.7 Jan 10, 2020
9 checks passed
9 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200109.16 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-eef1b02-3.7 branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

@ericvsmith ericvsmith

Assignees
No one assigned
Labels
🤖 automerge CLA signed skip issue skip news type-tests
Projects
None yet
Milestone
No milestone
6 participants
@miss-islington @csabella @ericvsmith @the-knights-who-say-ni @bedevere-bot @tirkarthi
You can’t perform that action at this time.