Skip to content

bpo-31698: add REQ_NAME macro #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-31698: add REQ_NAME macro #3926

wants to merge 4 commits into from

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Oct 9, 2017 •
edited by bedevere-bot
Loading

@csabella csabella requested a review from 1st1 May 21, 2019 01:48
@csabella csabella requested review from 1st1 and removed request for 1st1 December 13, 2019 02:51
@csabella csabella closed this Dec 13, 2019
@csabella csabella reopened this Dec 13, 2019
@csabella csabella removed the request for review from 1st1 January 18, 2020 13:48
@csabella
Copy link
Contributor

@JelleZijlstra, please resolve the merge conflicts. Thank you!

@JelleZijlstra
Copy link
Member Author

Done. But there's only one use case for this macro left because the way async is handled has changed, so I don't think this change is worth doing any more. (cc @1st1 who originally asked that I add the macro)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JelleZijlstra @csabella @the-knights-who-say-ni @bedevere-bot