Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39395: os.putenv() is now always available #18135
Open
+34
−102
Conversation
On non-Windows platforms, Python now requires setenv() to build.
This comment has been minimized.
This comment has been minimized.
|
If this PR is merged, I plan to also require unsetenv() to build and always make os.unsetenv() available, once https://bugs.python.org/issue39413 will be fixed. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 23, 2020
This comment has been minimized.
This comment has been minimized.
|
The PR built successfully on all tested buildbots: Linux (Ubuntu, Fedora, RHEL7, RHEL8, Gentoo, Arch Linux, ...), Windows (7, 8.1, 10, ...), macOS, FreeBSD. I checked the 3 buildbot failures: they are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 23, 2020
•
edited by bedevere-bot
On non-Windows platforms, Python now requires setenv() to build.
https://bugs.python.org/issue39395