Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39082: Fix: AsyncMock is unable to correctly patch static/class methods #17717
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 27, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
czardoz commentedDec 27, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39082
Essentially, patching a coroutinefunction decorated with
@classmethodor@staticmethoddoes not currently work correctly. Instead of creating anAsyncMock(),patch()uses aMock(), which fails when it's awaited on.https://bugs.python.org/issue39082