Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32598: Use autoconf to detect usable OpenSSL #5242

Merged
merged 1 commit into from Jan 20, 2018

Conversation

@tiran
Copy link
Member

tiran commented Jan 19, 2018

Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32598

@tiran tiran force-pushed the tiran:openssl_autoconf branch from 978906b to c4ae7c2 Jan 19, 2018
@tiran tiran changed the title Use autoconf to detect usable OpenSSL bpo-32598: Use autoconf to detect usable OpenSSL Jan 19, 2018
@tiran tiran requested a review from vstinner Jan 19, 2018
Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the tiran:openssl_autoconf branch from c4ae7c2 to e19151e Jan 19, 2018
@tiran

This comment has been minimized.

Copy link
Member Author

tiran commented Jan 19, 2018

The PR does not use HAVE_X509_VERIFY_PARAM_SET1_HOST. Once this PR has landed, I'll rebase #5128 and use it there.

@tiran tiran merged commit ff5be6e into python:master Jan 20, 2018
4 checks passed
4 checks passed
bedevere/issue-number Issue number 32598 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tiran tiran deleted the tiran:openssl_autoconf branch Jan 20, 2018
yan12125 added a commit to yan12125/python3-android that referenced this pull request Jun 16, 2018
And add pkg-config settings to fix the _ssl module on CPython.

As a side note, since python/cpython#5242,
pkg-config should be correctly set up to find non-common OpenSSL paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.