Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39320: Handle unpacking of *values in compiler #17984
Merged
+2,336
−2,347
Conversation
markshannon
force-pushed the
markshannon:handle-unpacking-in-compiler
branch
2 times, most recently
from
1f851c4
to
5dbab06
markshannon
force-pushed the
markshannon:handle-unpacking-in-compiler
branch
from
5dbab06
to
f920034
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 22, 2020
|
If you want to schedule another build, you need to add the " |
This comment has been minimized.
This comment has been minimized.
|
The PPC64 Fedora failure is a pre-existing problem. |
markshannon
merged commit 13bc139
into
python:master
43 of 44 checks passed
43 of 44 checks passed
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markshannon commentedJan 13, 2020
•
edited
Quoting bpo 39320:
We can replace the complex bytecodes used in unpacking with simpler, more focused ones.
Specifically the collection building operations:
can be replaced with simpler, and self-explanatory operations:
This PR implements those changes. (The proposed changes to ** unpacking will be implemented in another PR).
https://bugs.python.org/issue39320