bpo-35050: AF_ALG length check off-by-one error #10058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
type-bug
The length check for AF_ALG salg_name and salg_type had a off-by-one error. The code assumed that both values are not necessarily NULL terminated. However the Kernel code for alg_bind() ensures that the last byte of both strings are NULL terminated. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-35050-af_alg_null
branch
from
2a5e820 to
149840e
Compare
vstinner
requested changes
Oct 23, 2018
| @@ -0,0 +1 @@ | |||
| Fix off-by-one bug in length check for AF_ALG name and type. | |||
There was a problem hiding this comment.
please mention the socket module somewhere
|
When you're done making the requested changes, leave the comment: |
* reformat a comment * close the socket in the unit test
|
Sorry, @tiran and @vstinner, I could not cleanly backport this to |
|
Sorry, @tiran and @vstinner, I could not cleanly backport this to |
|
GH-11069 is a backport of this pull request to the 3.7 branch. |
|
GH-11070 is a backport of this pull request to the 3.6 branch. |
vstinner
added a commit
that referenced
this pull request
Dec 10, 2018
The length check for AF_ALG salg_name and salg_type had a off-by-one error. The code assumed that both values are not necessarily NULL terminated. However the Kernel code for alg_bind() ensures that the last byte of both strings are NULL terminated. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 2eb6ad8)
vstinner
added a commit
that referenced
this pull request
Dec 10, 2018
The length check for AF_ALG salg_name and salg_type had a off-by-one error. The code assumed that both values are not necessarily NULL terminated. However the Kernel code for alg_bind() ensures that the last byte of both strings are NULL terminated. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 2eb6ad8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length check for AF_ALG salg_name and salg_type had a off-by-one
error. The code assumed that both values are not necessarily NULL
terminated. However the Kernel code for alg_bind() ensures that the last
byte of both strings are NULL terminated.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue35050