Skip to content

bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000 #10620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2018
Merged

bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000 #10620

merged 4 commits into from
Dec 20, 2018

Conversation

AJNeufeld
Copy link
Contributor

@AJNeufeld AJNeufeld commented Nov 20, 2018 •
edited by bedevere-bot
Loading

Since Py_FinalizeEx() is "New in version 3.6", so should not be declared when
Py_LIMITED_API is less than 0x03060000

https://bugs.python.org/issue35259

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@vadmium
Copy link
Member

vadmium commented Nov 25, 2018

Revision 0e03603 looks okay to me. Thanks for fixing this.

@AJNeufeld
Copy link
Contributor Author

@serhiy-storchaka, does @vadmium's "looks okay to me" constitute a "review"? Enough to remove the "awaiting-review" label?

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Dec 20, 2018
@serhiy-storchaka serhiy-storchaka merged commit 3e8f962 into python:master Dec 20, 2018
@miss-islington
Copy link
Contributor

Thanks @AJNeufeld for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2018
@AJNeufeld @miss-islington
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (…
1a16280 
…pythonGH-10620)

(cherry picked from commit 3e8f962)

Co-authored-by: Arthur Neufeld <aneufeld@seinesoftware.ca>
@bedevere-bot
Copy link

GH-11268 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2018
@AJNeufeld @miss-islington
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (…
e9bf7ec 
…pythonGH-10620)

(cherry picked from commit 3e8f962)

Co-authored-by: Arthur Neufeld <aneufeld@seinesoftware.ca>
@bedevere-bot
Copy link

GH-11269 is a backport of this pull request to the 3.6 branch.

@serhiy-storchaka
Copy link
Member

Thank you for your contribution @AJNeufeld!

miss-islington added a commit that referenced this pull request Dec 20, 2018
@miss-islington @AJNeufeld
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (…
d1e7175 
…GH-10620)

(cherry picked from commit 3e8f962)

Co-authored-by: Arthur Neufeld <aneufeld@seinesoftware.ca>
ned-deily pushed a commit that referenced this pull request Dec 20, 2018
@miss-islington @AJNeufeld @ned-deily
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (…
5241ecf 
…GH-10620) (GH-11269)

(cherry picked from commit 3e8f962)

Co-authored-by: Arthur Neufeld <aneufeld@seinesoftware.ca>
@AJNeufeld AJNeufeld deleted the fix-issue-35259 branch December 21, 2018 21:03
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
@miss-islington @AJNeufeld @ned-deily
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (…
ffc106c 
…pythonGH-10620)

(cherry picked from commit 3e8f962)

Co-authored-by: Arthur Neufeld <aneufeld@seinesoftware.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vadmium vadmium Awaiting requested review from vadmium

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AJNeufeld @the-knights-who-say-ni @vadmium @miss-islington @bedevere-bot @serhiy-storchaka