bpo-35384: The repr of ctypes.CArgObject no longer fail for non-ascii character. #10863
Conversation
serhiy-storchaka
added
type-bug
Modules/_ctypes/callproc.c
Outdated
| @@ -514,8 +522,8 @@ PyCArg_repr(PyCArgObject *self) | |||
| break; | |||
|
|
|||
| default: | |||
| sprintf(buffer, "<cparam '%c' at %p>", | |||
| self->tag, self); | |||
| sprintf(buffer, "<cparam %02x' at %p>", | |||
There was a problem hiding this comment.
Looks as if this change accidentally removed the opening apostrophe.
| sprintf(buffer, "<cparam %02x' at %p>", | |
| sprintf(buffer, "<cparam '%02x' at %p>", |
There was a problem hiding this comment.
Actually the opposite. I have forgot to remove the closing apostrophe.
Modules/_ctypes/callproc.c
Outdated
| self->tag, self->value.c); | ||
| break; | ||
| if ((unsigned char)self->value.c < 128 | ||
| && _PyUnicode_IsPrintable(self->value.c) |
There was a problem hiding this comment.
Is printability the right test here? Tab, newline, carriage return, vertical tab, form feed are all printable but probably don't make sense in this context.
There was a problem hiding this comment.
'\t'.isprintable() returns False.
Modules/_ctypes/callproc.c
Outdated
| break; | ||
| if ((unsigned char)self->value.c < 128 | ||
| && _PyUnicode_IsPrintable(self->value.c) | ||
| && self->value.c != '\'') |
There was a problem hiding this comment.
Is the goal here to make the output look like a syntactically valid Python string? If so, you should also exclude backslash.
There was a problem hiding this comment.
Good catch. Yes, the goal here to make the output look like a syntactically valid Python or C.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10983 is a backport of this pull request to the 3.7 branch. |
…i character. (pythonGH-10863) (cherry picked from commit 3ffa8b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10984 is a backport of this pull request to the 3.6 branch. |
…i character. (pythonGH-10863) (cherry picked from commit 3ffa8b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-10985 is a backport of this pull request to the 3.7 branch. |
…i character. (pythonGH-10863) (cherry picked from commit 3ffa8b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
https://bugs.python.org/issue35384