Skip to content

bpo-32613: Update window FAQ #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2018
Merged

bpo-32613: Update window FAQ #5552

merged 2 commits into from
Nov 14, 2018

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Feb 5, 2018 •
edited by bedevere-bot
Loading

I dropped the whole section about python not being found, as I suspect does no longer happen since PEP 397 but I'm not a Windows user. I however just tried it on a VM and worked like a charm, and have lots of students, some on windows, and never had to make them configure their PATH to find py.

I also added a section about how to actually run a script, not just start a REPL, as it's the title of the section initially.

https://bugs.python.org/issue32613

csabella
csabella reviewed Feb 5, 2018
View reviewed changes
csabella
csabella reviewed Feb 5, 2018
View reviewed changes
csabella
csabella reviewed Feb 5, 2018
View reviewed changes
csabella
csabella reviewed Feb 5, 2018
View reviewed changes
@JulienPalard
Copy link
Member Author

Thanks for the review @csabella, I updated my PR.

@Mariatta
Copy link
Member

The doc build failed.

[faq/windows:56] ":d48eceb" found in "Python 3.6.4 (v3.6.4:d48eceb, Dec 19 2017, 06:04:45) [MSC v.1900 32 bit (Intel)] on win32"
make[1]: *** [build] Error 1
make[1]: Leaving directory `/home/travis/build/python/cpython/Doc'
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.

You need to update the entry for faq/windows in https://github.com/python/cpython/blob/master/Doc/tools/susp-ignored.csv

@JulienPalard
Copy link
Member Author

@Mariatta thanks for the explanation, I ignored the ignored.csv! It's fixed now.

@JulienPalard JulienPalard merged commit 6431347 into python:master Nov 14, 2018
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @JulienPalard, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 64313478bcbd0a708c3ce5d4d14f977da56e4be9 3.7

@miss-islington
Copy link
Contributor

Sorry, @JulienPalard, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 64313478bcbd0a708c3ce5d4d14f977da56e4be9 3.6

JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Nov 14, 2018
@JulienPalard
[3.7] bpo-32613: Update window FAQ (pythonGH-5552).
0319d68 
(cherry picked from commit 6431347)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link

GH-10544 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-10545 is a backport of this pull request to the 3.6 branch.

JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Nov 14, 2018
@JulienPalard
[3.6] bpo-32613: Update window FAQ (pythonGH-5552).
78463cc 
(cherry picked from commit 6431347)

Co-authored-by: Julien Palard <julien@palard.fr>
miss-islington pushed a commit that referenced this pull request Nov 14, 2018
@JulienPalard @miss-islington
[3.7] bpo-32613: Update window FAQ (GH-5552). (GH-10544)
9053d2f 
(cherry picked from commit 6431347)

Co-authored-by: Julien Palard <julien@palard.fr>



https://bugs.python.org/issue32613
miss-islington pushed a commit that referenced this pull request Nov 14, 2018
@JulienPalard @miss-islington
[3.6] bpo-32613: Update window FAQ (GH-5552). (GH-10545)
137da0c 
(cherry picked from commit 6431347)

Co-authored-by: Julien Palard <julien@palard.fr>



https://bugs.python.org/issue32613
@JulienPalard JulienPalard deleted the issue32613 branch June 16, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella left review comments

Assignees

@JulienPalard JulienPalard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JulienPalard @Mariatta @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni