New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39416: Document some restrictions on the default string representations of numeric classes #18111

Open

kpinc wants to merge 3 commits into python:master from kpinc:numeric_doc

+19 −0

kpinc commented Jan 22, 2020 •

edited by bedevere-bot

bpo-39416: Document string representations of the Numeric classes

This is a change to the specification of the Python language.

The idea here is to put sane minimal limits on the Python language's default
representations of its Numeric classes. That way "Marty's Robotic Massage Parlor
and Python Interpreter" implementation of Python won't do anything too
crazy.

Some discussion in the email thread:
Subject: Documenting Python's float.str()
https://mail.python.org/archives/list/python-dev@python.org/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/

https://bugs.python.org/issue39416


        Restrict Python's Numeric classes default external representations

d6fd38e

the-knights-who-say-ni added the CLA not signed label

the-knights-who-say-ni commented Jan 22, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added type-documentation awaiting review labels

kpinc changed the title ~~Restrict Python's Numeric classes default external representations~~ bpo-39416: Restrict Python's Numeric classes default external representations

Author

kpinc commented Jan 22, 2020

Note that the "when possible" in "The representation is in base 10, when possible."
is because of things like NaN, inf, etc.

Contributor

merwok commented Jan 22, 2020

You can use this web app to add a NEWS entry: https://blurb-it.herokuapp.com/

merwok removed the CLA not signed label

the-knights-who-say-ni added the CLA not signed label


        📜🤖 Added by blurb_it.

66a1794

Author

kpinc commented Jan 22, 2020

You can use this web app to add a NEWS entry: https://blurb-it.herokuapp.com/

Thanks. Done.

aeros requested a review from mdickinson

merwok reviewed

Misc/NEWS.d/next/Documentation/2020-01-22-05-14-53.bpo-39416.uYjhEm.rst Outdated Show resolved Hide resolved

merwok changed the title ~~bpo-39416: Restrict Python's Numeric classes default external representations~~ bpo-39416: restrict numeric classes default external representations

merwok closed this

merwok reopened this

Contributor

merwok commented Jan 22, 2020

Sorry, clicked on the close button by mistake!

I edited the title to remove redundant Python and change Numeric (a specific ABC) to numeric (a more general concept). From the PR description, I get that the goal here is to change the language doc, not to change any existing code, so I would suggest to edit the title to match the wording used in the news entry.


        Change news entry text to better description

091bbc7

kpinc changed the title ~~bpo-39416: restrict numeric classes default external representations~~ bpo-39416: Document some restrictions on the default string representations of numeric classes

Author

kpinc commented Jan 22, 2020

Sorry, clicked on the close button by mistake!

And here I thought you were making my life simpler. ;-)

From the PR description, I get that the goal here is to change the language doc, not to change any existing code, so I would suggest to edit the title to match the wording used in the news entry.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.