Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h #18052

Merged
merged 1 commit into from Jan 20, 2020

Conversation

@ncoghlan
Copy link
Contributor

ncoghlan commented Jan 18, 2020

The patch for PEP 558 (bpo-30744) adds a number of new frame-related
C APIs. This prepatory patch migrates frameobject.h to the modern layout
with multiple include files so the PEP reference implementation can clearly
separate the stable ABI additions from the full CPython C API additions.

https://bugs.python.org/issue35134

Copy link
Member

vstinner left a comment

LGTM. You can use bpo-35134 in the commit title if you want.

@ncoghlan ncoghlan changed the title Migrate frameobject.h contents to cpython/frameobject.h bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h Jan 20, 2020
@ncoghlan ncoghlan removed the skip issue label Jan 20, 2020
@ncoghlan ncoghlan merged commit 1e420f8 into python:master Jan 20, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200118.32 succeeded
Details
bedevere/issue-number Issue number 35134 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan ncoghlan deleted the ncoghlan:move-frameobject-header branch Jan 20, 2020
@ncoghlan

This comment has been minimized.

Copy link
Contributor Author

ncoghlan commented Jan 20, 2020

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.