Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMove test_math tests #18098
Merged
Move test_math tests #18098
Conversation
testPerm() and testComb() belong to MathTests, not to IsCloseTests(). test_nextafter() and test_ulp() now use assertIsNaN().
This comment has been minimized.
This comment has been minimized.
|
Once this PR will be merged into master, I will backport it manually to 3.8 (since 3.8 doesn't need the "test_nextafter() and test_ulp() now use assertIsNaN()" change). |
|
LGTM. Thank you! |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Jan 21, 2020
This comment has been minimized.
This comment has been minimized.
|
3.8 backport: #18102 |
vstinner
added a commit
that referenced
this pull request
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 21, 2020
testPerm() and testComb() belong to MathTests, not to IsCloseTests().
test_nextafter() and test_ulp() now use assertIsNaN().