Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-24337: Implement email.message.Message.__repr__() #18127

Open
wants to merge 1 commit into
base: master
from
Open

bpo-24337: Implement email.message.Message.__repr__() #18127

wants to merge 1 commit into from
+12 −0

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Jan 22, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue24337
@ZackerySpytz
bpo-24337: Implement email.message.Message.__repr__()
Loading status checks…
78c5c37
@ZackerySpytz ZackerySpytz requested a review from python/email-team as a code owner Jan 22, 2020
@bitdancer
bitdancer requested changes Jan 22, 2020
View changes
Lib/email/message.py
@@ -134,6 +134,10 @@ def __str__(self):
"""
return self.as_string()

def __repr__(self):
return f"{self.__class__.__name__} with {len(self._headers)} " \
f"headers and Content-Type {self._default_type}"

This comment has been minimized.

Sign in to view
Copy link
@bitdancer

bitdancer Jan 22, 2020

Member

This doesn't match the suggestion in the issue. self._default_type is also wrong, since that's just the default, not the actual content-type of the message (which comes from the headers).

What exactly goes in the repr should be discussed further in the issue.
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 22, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdancer bitdancer

Assignees
No one assigned
Labels
CLA signed awaiting changes
Projects
None yet
Milestone
No milestone
4 participants
@ZackerySpytz @bedevere-bot @bitdancer @the-knights-who-say-ni
You can’t perform that action at this time.