Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Documentation Improvements #17696

Merged
merged 1 commit into from Dec 25, 2019
Merged

Minor Documentation Improvements #17696

merged 1 commit into from Dec 25, 2019

Conversation

@WillAyd
Copy link
Contributor

WillAyd commented Dec 25, 2019

The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:

warning: using the result of an assignment as a condition without parentheses [-Wparentheses]

The other change is a typo fix
@WillAyd
Fixed minor doc typos
Loading status checks…
4d0e124
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Dec 25, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@WillAyd

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@WillAyd

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

WillAyd commented Dec 25, 2019

Already signed CLA; waiting for it to work its way through the system
@benjaminp benjaminp merged commit 5c7ed75 into python:master Dec 25, 2019
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20191225.1 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 25, 2019

Thanks @WillAyd for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 25, 2019

GH-17697 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 25, 2019
@WillAyd @miss-islington
Minor C API documentation improvements. (pythonGH-17696)
47b5468 
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 25, 2019

GH-17698 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Dec 25, 2019

Sorry, @WillAyd and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5c7ed7550ec2da16d7679e538fcd7c1a5631811f 2.7
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 25, 2019
@WillAyd @miss-islington
Minor C API documentation improvements. (pythonGH-17696)
d9ff4ea 
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
benjaminp added a commit that referenced this pull request Dec 25, 2019
@WillAyd @benjaminp
[2.7] Minor C API documentation improvements. (GH-17696)
Loading status checks…
b5ca84e 
The added parentheses around the PyIter_Next assignment suppress the following warning which gcc throws without:
```
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
```
The other change is a typo fix.
(cherry picked from commit 5c7ed75)

Co-authored-by: William Ayd <william.ayd@icloud.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Dec 25, 2019

GH-17699 is a backport of this pull request to the 2.7 branch.
sthagen added a commit to sthagen/cpython that referenced this pull request Dec 25, 2019
@sthagen
Merge pull request #118 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
731c9a1 
Minor C API documentation improvements. (pythonGH-17696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjaminp benjaminp

Labels
CLA not signed skip issue skip news
Projects
None yet
Milestone
No milestone
5 participants
@WillAyd @the-knights-who-say-ni @miss-islington @bedevere-bot @benjaminp
You can’t perform that action at this time.