Skip to content

bpo-38534: Replace wrong KB number references #16955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

bpo-38534: Replace wrong KB number references #16955

merged 1 commit into from
Oct 28, 2019

Conversation

benedwards14
Copy link
Contributor

@benedwards14 benedwards14 commented Oct 27, 2019 •
edited by bedevere-bot
Loading

This is my first contribution to CPython.

I'm fixing the issue from:
https://bugs.python.org/issue38534

https://bugs.python.org/issue38534

@benedwards14 benedwards14 requested a review from a team as a code owner October 27, 2019 12:45
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@benedwards14

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@benedwards14 benedwards14 changed the title bpo:38534: Replace wrong KB number references bpo-38534: Replace wrong KB number references Oct 27, 2019
@benedwards14
Copy link
Contributor Author

Have signed the CLA, and am waiting for approval

@zooba zooba merged commit 794616f into python:master Oct 28, 2019
@miss-islington
Copy link
Contributor

Thanks @benedwards14 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zooba
Copy link
Member

zooba commented Oct 28, 2019

Thanks!

@bedevere-bot
Copy link

GH-16969 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 28, 2019
@miss-islington @benedwards14
bpo-38534: Replace wrong KB number references (GH-16955)
a4ee7ab 
(cherry picked from commit 794616f)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@benedwards14
bpo-38534: Replace wrong KB number references (pythonGH-16955)
e9fc3e9
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@benedwards14 @shihai1991
bpo-38534: Replace wrong KB number references (pythonGH-16955)
9c13eff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benedwards14 @the-knights-who-say-ni @miss-islington @zooba @bedevere-bot @ammaraskar