Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39413: Implement os.unsetenv() on Windows #18163
Conversation
The os.unsetenv() function is now also available on Windows.
This comment has been minimized.
This comment has been minimized.
@eryksun @serhiy-storchaka: Here is a simpler implementation of os.unsetenv() for Windows.
In practice,os.unsetenv() rejects "=" anywhere in the name on all platforms: it's now validated by unit tests. I chose to not change raised exceptions (ValueError vs OSError) for invalid variable name in this PR. I plan to propose a separated PR to unify the raised exception on all platforms. I also chose to not remove the Windows maximum variable length limit in this PR, again to make it easier to review. I also plan to propose a separated PR to limit this outdated limit. |
161e7b3
into
python:master
This comment has been minimized.
This comment has been minimized.
|
vstinner commentedJan 24, 2020
•
edited by bedevere-bot
The os.unsetenv() function is now also available on Windows.
https://bugs.python.org/issue39413