Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35826: Fix typo in equivalent code of async with cond #11681

Merged
merged 1 commit into from Feb 14, 2019
Merged

bpo-35826: Fix typo in equivalent code of async with cond #11681

merged 1 commit into from Feb 14, 2019

Conversation

mhchia
Copy link
Contributor

@mhchia mhchia commented Jan 26, 2019 •
edited by bedevere-bot

Issues

The equivalent example code of async with statement with asyncio.Condition has a typo. lock.xxx should be changed to cond.xxx.

Changes

  • lock.acquire to cond.acquire
  • lock.release to cond.release

https://bugs.python.org/issue35826

@mhchia
Fix typo: equivalent code of async with cond
f30e791 
Change `lock.xxx` to `cond.xxx`
@mhchia mhchia requested review from 1st1 and asvetlov as code owners Jan 26, 2019
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jan 26, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 26, 2019
tirkarthi
tirkarthi approved these changes Jan 30, 2019
View changes
Copy link
Member

@tirkarthi tirkarthi left a comment •
edited

LGTM. Thanks.

Edit: You can try triggering AppVeyor by closing and opening the PR.

@mhchia
Copy link
Contributor Author

mhchia commented Jan 30, 2019 •
edited

Thanks for the pointer! I'm trying it now:)

@mhchia mhchia closed this Jan 30, 2019
@mhchia mhchia reopened this Jan 30, 2019
@lisroach lisroach merged commit d73ac0e into python:master Feb 14, 2019
@lisroach
Copy link
Contributor

lisroach commented Feb 14, 2019

Thank you! 👍

@mhchia mhchia deleted the fix-typo-asyncio-cond branch Feb 14, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2019

Thanks @mhchia for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2019

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2019

Thanks @mhchia for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2019

GH-16720 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2019
@mhchia @miss-islington
Fix typo: equivalent code of async with cond (pythonGH-11681)
097e113 
(cherry picked from commit d73ac0e)

Co-authored-by: Kevin Mai-Husan Chia <mhchia@users.noreply.github.com>
lisroach pushed a commit that referenced this pull request Oct 11, 2019
@miss-islington @lisroach
Fix typo: equivalent code of async with cond (GH-11681) (GH-16720)
1845997
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
@miss-islington @ned-deily
Fix typo: equivalent code of async with cond (pythonGH-11681) (pyth…
c16897c 
…onGH-16720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mhchia @the-knights-who-say-ni @lisroach @miss-islington @bedevere-bot @tirkarthi