Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an incorrect sentence in the docs #17205

Merged
merged 2 commits into from Nov 21, 2019
Merged

Fixed an incorrect sentence in the docs #17205

merged 2 commits into from Nov 21, 2019

Conversation

Aveheuzed
Copy link
Contributor

@Aveheuzed Aveheuzed commented Nov 17, 2019 •
edited by miss-islington

Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella

@Aveheuzed
Fixed an incorrect sentence in the docs
c293ee7 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 17, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Aveheuzed

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 17, 2019
@interrogator
Copy link

interrogator commented Nov 18, 2019 •
edited

This PR introduces a typo into the docs. Do not merge this until alway -> always

@Aveheuzed
Copy link
Contributor Author

Aveheuzed commented Nov 18, 2019

Right, sorry. It would be silly to introduce a typo while correcting another... ;)

@csabella csabella added needs backport to 3.7 needs backport to 3.8 🤖 automerge PR will be merged once it's been approved and all CI passed labels Nov 21, 2019
csabella
csabella approved these changes Nov 21, 2019
View changes
Copy link
Contributor

@csabella csabella left a comment

LGTM! Thank you for the contribution, @Aveheuzed.

@miss-islington miss-islington merged commit 06ca2a2 into python:master Nov 21, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 21, 2019

Thanks @Aveheuzed for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@Aveheuzed @miss-islington
Fixed an incorrect sentence in the docs (pythonGH-17205)
2f31985 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
(cherry picked from commit 06ca2a2)

Co-authored-by: Aveheuzed <a.masson555@ntymail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 21, 2019

GH-17305 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2019
@Aveheuzed @miss-islington
Fixed an incorrect sentence in the docs (pythonGH-17205)
847267d 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
(cherry picked from commit 06ca2a2)

Co-authored-by: Aveheuzed <a.masson555@ntymail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 21, 2019

GH-17306 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @Aveheuzed
Fixed an incorrect sentence in the docs (GH-17205)
7efeb75 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
(cherry picked from commit 06ca2a2)

Co-authored-by: Aveheuzed <a.masson555@ntymail.com>
miss-islington added a commit that referenced this pull request Nov 21, 2019
@miss-islington @Aveheuzed
Fixed an incorrect sentence in the docs (GH-17205)
c5fe339 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
(cherry picked from commit 06ca2a2)

Co-authored-by: Aveheuzed <a.masson555@ntymail.com>
@Aveheuzed Aveheuzed deleted the mapping.rst branch Nov 21, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Aveheuzed
Fixed an incorrect sentence in the docs (pythonGH-17205)
78902fc 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Aveheuzed @shihai1991
Fixed an incorrect sentence in the docs (pythonGH-17205)
44d31a7 
Fixed an incorrect sentence in Doc/c-api/mapping.rst I fell on
while translating the file.

skip issue

Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Aveheuzed @the-knights-who-say-ni @interrogator @miss-islington @bedevere-bot @csabella @taleinat