Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.6] bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) #11299
+1
−1
Conversation
`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only. https://bugs.python.org/issue35257 (cherry picked from commit 44a3ee0) Co-authored-by: Ned Deily <nad@python.org>
This comment has been minimized.
This comment has been minimized.
|
@ned-deily: Status check is done, and it's a success |
This comment has been minimized.
This comment has been minimized.
|
Sorry, I can't merge this PR. Reason: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedDec 23, 2018
•
edited by bedevere-bot
BLDSHAREDneeds to have bothLDFLAGSandLDFLAGS_NODIST, not justLDFLAGS_NODIST;PY_CORE_LDFLAGSprovides both. For example, as it stands now with justLDFLAGS_NODIST, macOS universal builds are broken as the necessary-archflags are no longer passed to the standard library extension module link step fromsetup.pyresulting in extension modules being single architecture only.https://bugs.python.org/issue35257
(cherry picked from commit 44a3ee0)
Co-authored-by: Ned Deily nad@python.org
https://bugs.python.org/issue35257