Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39082: Allow AsyncMock to correctly patch static/class methods #18116

Open
wants to merge 3 commits into
base: master
from
Open

bpo-39082: Allow AsyncMock to correctly patch static/class methods #18116

wants to merge 3 commits into from
+26 −0

Conversation

@mkokotovich
Copy link

mkokotovich commented Jan 22, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39082
@mkokotovich
bpo-39082: Allow AsyncMock to correcly patch static/class methods
Loading status checks…
74a063a
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 22, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mkokotovich

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@mkokotovich mkokotovich requested a review from lisroach Jan 22, 2020
@cjw296

This comment has been minimized.

Sign in to view
Copy link
Contributor

cjw296 commented Jan 24, 2020

This is an exact duplicate of #17717 so closing.
@cjw296 cjw296 closed this Jan 24, 2020
@mkokotovich

This comment has been minimized.

Sign in to view
Copy link
Author

mkokotovich commented Jan 24, 2020

It isn't an exact duplicate, it contains the alternate solution that was provided in the bug report. I'm fine if you all decide to use the other solution, but I wanted to get this one out there too to make it easier to decide.
@cjw296 cjw296 reopened this Jan 24, 2020
@cjw296

This comment has been minimized.

Sign in to view
Copy link
Contributor

cjw296 commented Jan 24, 2020 •
edited

Terribly sorry, I missed that. I think this actually has @tirkarthi's suggestion which I'd be inclined to go with. Would you be able to add a NEWS entry so I can merge this?
@cjw296 cjw296 mentioned this pull request Jan 24, 2020
Closed
@mkokotovich
added NEWS entry
Loading status checks…
ff16a46
@mkokotovich

This comment has been minimized.

Sign in to view
Copy link
Author

mkokotovich commented Jan 24, 2020

Let me know if I didn't do that correctly, but I added a NEWS entry.
@lisroach
lisroach reviewed Jan 24, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-24-13-24-35.bpo-39082.qKgrq_.rst Outdated
@@ -0,0 +1 @@
Allow AsyncMock to correcly patch static/class methods

This comment has been minimized.

Sign in to view
Copy link
@lisroach

lisroach Jan 24, 2020

Contributor

correcly -> correctly :)

This comment has been minimized.

Sign in to view
Copy link
@mkokotovich

mkokotovich Jan 24, 2020

Author

Thanks!
@mkokotovich
mkokotovich reviewed Jan 24, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-24-13-24-35.bpo-39082.qKgrq_.rst Outdated Show resolved Hide resolved
@mkokotovich
Update Misc/NEWS.d/next/Library/2020-01-24-13-24-35.bpo-39082.qKgrq_.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
34af56d
@mkokotovich mkokotovich changed the title bpo-39082: Allow AsyncMock to correcly patch static/class methods bpo-39082: Allow AsyncMock to correctly patch static/class methods Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisroach lisroach

Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
5 participants
@mkokotovich @the-knights-who-say-ni @cjw296 @lisroach @bedevere-bot
You can’t perform that action at this time.