Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkify SMTP.quit() in smtplib documentation. #9785

Merged
merged 2 commits into from Nov 23, 2018
Merged

Linkify SMTP.quit() in smtplib documentation. #9785

merged 2 commits into from Nov 23, 2018

Conversation

taketakeyyy
Copy link
Contributor

@taketakeyyy taketakeyyy commented Oct 10, 2018

No description provided.

@taketakeyyy taketakeyyy requested a review from a team as a code owner Oct 10, 2018
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 10, 2018
@JulienPalard
Copy link
Member

JulienPalard commented Oct 10, 2018

Hi and thanks for you PR.

This was not a typo, the ~ masks the first element of the reference, so instead of displaying smtplib.quit, only quit is shown.

But there's a bigger error, quit is not from smtplib but from SMTP instances, so what about:

:meth:`SMTP.quit`

? This would create a clickable link to the quit method, instead of unclickable-text to a non-existing method.

@taketakeyyy
Copy link
Contributor Author

taketakeyyy commented Oct 10, 2018

Thank you for teaching me! I misunderstood.
The cause why it is not clickable is just what you said, I think.
should I fix it with other PR?

@matrixise
Copy link
Member

matrixise commented Oct 12, 2018

Hi @taketakeyyy just add a new commit to this PR where you fix with

:meth:`SMTP.quit`

@taketakeyyy
Copy link
Contributor Author

taketakeyyy commented Oct 13, 2018

@matrixise
thank you for your advice!

@Mariatta Mariatta changed the title fix: typo Linkify SMTP.quit() in smtplib documentation. Nov 23, 2018
@Mariatta Mariatta added needs backport to 3.6 needs backport to 3.7 🤖 automerge PR will be merged once it's been approved and all CI passed labels Nov 23, 2018
@miss-islington miss-islington merged commit ba57963 into python:master Nov 23, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Nov 23, 2018

Thanks @taketakeyyy for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
3e1cf1f 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 23, 2018

GH-10681 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 23, 2018

GH-10682 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 23, 2018

GH-10683 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
3d7d4a9 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
8901e05 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
70cc092 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
832da87 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
0ef0398 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
pablogsal pushed a commit that referenced this pull request Apr 29, 2020
@tonybaloney
bpo-40432 Fix MSBuild project for Pegen grammars (#GH-9785)
9b64ef3 
* Update the source path of the pegen target within the Windows regen project.
Change the path to Windows path formats.

* Use the more reliable SetEnv task for Cpp Projects in MSBuild.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

@python/email-team email-team

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@taketakeyyy @JulienPalard @matrixise @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni