Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[3.7] bpo-35182: fix communicate() crash after child closes its pipes (GH-18117) #18151
Conversation
…GH-17020) (GH-18117) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>. (cherry picked from commit d3ae95e) Co-authored-by: Alex Rebert <alex@forallsecure.com>
miss-islington
merged commit 61b3484
into
python:3.7
10 checks passed
10 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alpire commentedJan 23, 2020
•
edited by miss-islington
When communicate() is called in a loop, it crashes when the child process
has already closed any piped standard stream, but still continues to be running
Co-authored-by: Andriy Maletsky andriy.maletsky@gmail.com.
(cherry picked from commit d3ae95e)
Co-authored-by: Alex Rebert alex@forallsecure.com
https://bugs.python.org/issue35182
Automerge-Triggered-By: @gpshead